alamb commented on code in PR #12022:
URL: https://github.com/apache/datafusion/pull/12022#discussion_r1719085598
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -128,14 +128,14 @@ impl AggregateMode {
#[derive(Clone, Debug, Default)]
pub struct PhysicalGroupBy {
/// Distinct (Physical Expr, Alias) in the grouping set
- expr: Vec<(Arc<dyn PhysicalExpr>, String)>,
+ pub expr: Vec<(Arc<dyn PhysicalExpr>, String)>,
Review Comment:
A potentially more future proof API might be to make accessors for these
fields
like
```rust
pub fn null_expr(&self) -> &[...]
```
##########
datafusion/physical-plan/src/aggregates/order/full.rs:
##########
@@ -142,3 +142,9 @@ impl GroupOrderingFull {
std::mem::size_of::<Self>()
}
}
+
+impl Default for GroupOrderingFull {
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
