emgeee commented on code in PR #12022:
URL: https://github.com/apache/datafusion/pull/12022#discussion_r1720330041
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -128,14 +128,14 @@ impl AggregateMode {
#[derive(Clone, Debug, Default)]
pub struct PhysicalGroupBy {
/// Distinct (Physical Expr, Alias) in the grouping set
- expr: Vec<(Arc<dyn PhysicalExpr>, String)>,
+ pub expr: Vec<(Arc<dyn PhysicalExpr>, String)>,
Review Comment:
ah, i just noticed that these properties do have accessors already so let me
revert this chagne
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
