andygrove commented on PR #5374: URL: https://github.com/apache/datafusion-comet/pull/5374#issuecomment-5330145285
Thanks @mbutrovich, all seven addressed in the two commits above. The two that changed more than the runner: the `jdk17` profile now activates on `<jdk>[17,)</jdk>` in `pom.xml`, which fixes the JDK 21 problem for every Maven invocation and let me delete the `-Pjdk17` workaround, and the `Makefile` now exposes the benchmark invocation through `print-benchmark-args` so `run.py` reads it instead of restating it. `DEFAULT_SUITES` is gone in favour of discovering the suites from the benchmark sources, which turned up `CometReadHdfsBenchmark` sitting in neither list. Details in the individual replies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
