alamb commented on PR #23828: URL: https://github.com/apache/datafusion/pull/23828#issuecomment-5333311301
> > cc @jayzhan211, @xudong963, and @alamb, would you like to take another look and move forward? > > datafusion project typically wait for 24 hrs after approval to merge, so others can have a chance to look. This one is a larger PR, probably we could wait for 2 days, unless anyone need more time to review. > > https://datafusion.apache.org/contributor-guide/pr_review.html#pr-review-mechanics Given @2010YOUY01 and @jayzhan211 have reviewed and approved I am happy to have this merged without my review (I am currently focusing a bit lower with arrow/parquet and trying to keep them going along) I did however add this feature to the list of things to list in the next release when we get there - https://github.com/apache/datafusion/issues/24461 Nice work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
