shinzoxD commented on code in PR #24402: URL: https://github.com/apache/datafusion/pull/24402#discussion_r3815166582
########## datafusion/sqllogictest/test_files/case.slt: ########## @@ -655,6 +655,38 @@ NULL NULL -1 +# Swapped comparison form of the same pattern Review Comment: Addressed in e91860399: added `CASE WHEN 0 > d THEN n / d ELSE NULL END` over `(1, 1), (1, 0), (1, -1)` => `NULL, NULL, -1` next to the existing swapped `0 < d` test in `case.slt`, so planner-to-physical matching stays covered for this SQL spelling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
