emilk opened a new pull request, #24566:
URL: https://github.com/apache/datafusion/pull/24566
## Which issue does this PR close?
- Part of #18467.
## Rationale for this change
Continuing to turn on `clippy::pedantic` lints (opt-out list in
`Cargo.toml`), one lint per commit, per the pattern started in #24466.
## What changes are included in this PR?
One commit per lint, each removing its `allow` line and fixing every site:
| Lint | Fix |
| ---- | --- |
| `no_effect_underscore_binding` | removed a dead `let _expected = …` |
| `case_sensitive_file_extension_comparisons` | use `Path::extension()`
instead of `ends_with(".csv")` |
| `cast_ptr_alignment` | `#[expect]` on 3 FFI tests that downcast to a
concrete (aligned) type |
| `doc_link_with_quotes` | quoted doc "links" turned into real intra-doc
links or backticked code |
| `ref_option` | `&Option<T>` params/returns changed to `Option<&T>` (mostly
internal; one public fn in `datafusion-substrait` touched) |
| `needless_continue` | dropped `continue`s that already ended the loop
iteration |
| `cloned_instead_of_copied` | `cloned()` -> `copied()` for `Copy` types |
| `unnecessary_semicolon` | dropped semicolons after tail `match`/`if` |
| `unnecessary_trailing_comma` | dropped trailing commas after single-item
parens/brackets |
Review one commit at a time. Let me know if you disagree with any and I'll
revert it.
## Are these changes tested?
No new tests; existing test suite covers these files. `cargo clippy
--all-targets --all-features` is clean.
## Are there any user-facing changes?
The `ref_option` commit changes the signature of the public `apply_masking`
fn in `datafusion-substrait` (`&Option<MaskExpression>` ->
`Option<&MaskExpression>`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
