theirix opened a new pull request, #24577: URL: https://github.com/apache/datafusion/pull/24577
## Which issue does this PR close? - Closes #24576 ## Rationale for this change A follow-up for https://github.com/apache/datafusion/pull/24419, which introduced pure-decimal interpolation, where a smaller interpolation precision was used for `Decimal32` types with Euclidean interpolation. Seems like, a smaller precision for `Decimal32` is not enough, and the value was saturated to zero. Solution - just widen `i32` inputs to `i64` to handle edge cases. In this case, we can use the same logical interpolation precision `10^6` everywhere. ## What changes are included in this PR? - Interpolation precision is now the only one - `scale_by_num` now widens `i32 `inputs to `i64` ## Are these changes tested? - The mentioned case - More test cases to overflow the interpolator, matched with DuckDB and DataFusion floating interpolator ## Are there any user-facing changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
