DevShiba commented on PR #24218: URL: https://github.com/apache/datafusion/pull/24218#issuecomment-5380006245
@kosiew Done — resolved. `main` had moved 59 commits since the last sync, with two real content conflicts in `dynamic_filter_pushdown_config.slt` and `parquet_nested_schema_pruning.slt` (both from further schema-pruning work landing upstream, same as last time). Also found something worth flagging: `main` picked up a brand new `bytes_processed` metric (`datafusion/datasource-parquet/src/metrics.rs`) in the meantime, registered via the plain `.counter(...)` builder + `MetricCategory::Bytes` — the exact same bug this PR fixes, just introduced independently in a different PR after this one was opened. Switched it to `.bytes_counter(...)` and confirmed the corrected value (`1147.0 B`) against a real test run rather than computing it by hand. Verified after merging (twice, since I initially staged the sqllogictest fixture fix before running the sed that filled in the confirmed values, so my first merge commit was wrong until I caught it against `git diff HEAD`): the exact three commands the CI jobs run, the exact clippy script, `cargo fmt --check`, the full `datafusion-ffi --features integration-tests` suite, and the two directly-touched sqllogictest files — all clean against the actual committed state, not just the working tree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
