kosiew commented on code in PR #24675:
URL: https://github.com/apache/datafusion/pull/24675#discussion_r3862674380
##########
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##########
@@ -3872,24 +3871,34 @@ pub(crate) mod tests {
.await?;
}
Review Comment:
Could we add a tight-memory, single-right-partition spill test for
`LeftSemi`, `LeftAnti`, and `LeftMark` as well? The new gate specifically
applies when there is more than one right partition, but the current
single-partition success coverage only exercises `Left` and `Full`. Adding
these cases would help make sure the supported single-partition fallback
continues to work while #22038 remains open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
