pingzh opened a new pull request, #5475: URL: https://github.com/apache/datafusion-comet/pull/5475
## Which issue does this PR close? Part of #5352. Follow-up to #5473; does not close the issue. ## Rationale for this change Address two review comments from #5473: 1. `RssPartitionWriter` was publicly exported despite implementing a crate-private trait, making its operational methods inaccessible to external crates. 2. JNI payload validation accepted `Integer.MAX_VALUE`, although JVM implementations may reject arrays approaching that size. ## What changes are included in this PR? - Keep `RssPartitionWriter` and its constructor crate-private, consistent with `LocalPartitionWriter`. - Remove the unnecessary public re-exports. - Limit JNI payloads to OpenJDK’s conservative soft array maximum: `Integer.MAX_VALUE - 8`. - Add boundary coverage for accepted and rejected payload lengths. ## How are these changes tested? - All 25 JNI-bridge unit tests pass. - All 50 native shuffle unit tests pass. - `cargo fmt --all -- --check` passes. - `cargo clippy --color=never --all-targets --workspace -- -D warnings` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
