kosiew commented on code in PR #24493: URL: https://github.com/apache/datafusion/pull/24493#discussion_r3870509457
########## datafusion/sqllogictest/bin/sqllogictests.rs: ########## Review Comment: Could we avoid duplicating the per-combination dispatch between `run_test_file_substrait_round_trip` and `run_test_file`? The two paths differ mainly in the engine they construct, the runner label, and the label passed to `count_records`, but each independently calls `run_each_configuration`. I think it would be safer to collapse this into one function parameterized by a runner factory, leaving a single call site for `run_each_configuration`. Otherwise a future change could accidentally bypass the matrix loop in the feature-gated Substrait path while leaving the default path correct. That is essentially the structural version of the earlier Substrait bypass we fixed in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
