sunchao commented on PR #5415: URL: https://github.com/apache/datafusion-comet/pull/5415#issuecomment-5442789711
@andygrove, two factual clarifications against `c62b529a` for [these questions](https://github.com/apache/datafusion-comet/pull/5415#issuecomment-5441731820): - The description already includes author-reported **4.6–28.8× versus the JVM dispatcher** for the stated ASCII workload. Those measurements do not establish what fraction of representative real-world patterns the whitelist admits. - The [parity suite](https://github.com/apache/datafusion-comet/blob/c62b529a75867ab54c3a95c456fa7e7b419b91bf/spark/src/test/scala/org/apache/comet/CometRegexParitySuite.scala#L37) runs Comet-enabled queries against Comet-disabled Spark results, with operator/dispatcher checks; admitted literals route to the [native expression builder](https://github.com/apache/datafusion-comet/blob/c62b529a75867ab54c3a95c456fa7e7b419b91bf/native/core/src/execution/expressions/strings.rs#L54). It is fixed-corpus coverage, not just Java-versus-expected-values checks, but it cannot guard every possible crate semantic change. Grammar generation and representative admission-rate measurements would add evidence beyond that coverage. The constants' structural limits are also not a compiled-byte guarantee; the existing [compile-budget P2 discussion](https://github.com/apache/datafusion-comet/pull/5415#discussion_r3836596236) remains relevant. No tests or benchmarks were rerun for this clarification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
