Rich-T-kid commented on code in PR #24227:
URL: https://github.com/apache/datafusion/pull/24227#discussion_r3878263400
##########
datafusion/datasource-parquet/src/file_format.rs:
##########
@@ -210,6 +213,22 @@ impl ParquetFormat {
&self.options
}
+ /// Restrict RLE->Dictionary promotion to a named subset of columns.
+ ///
+ /// Only columns in `columns` that also have dictionary pages in the file
+ /// are promoted to `Dictionary(Int32, …)` in the inferred schema.
+ /// Overrides `enable_rle_to_dictionary` when set; an empty set disables
+ /// promotion entirely. See
<https://github.com/apache/datafusion/issues/24113>.
+ pub fn with_rle_column_allowlist(mut self, columns: HashSet<String>) ->
Self {
Review Comment:
this makes sense to me, less things to introduce in 1 PR the easier it will
be to catch bugs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
