Amogh-2404 commented on code in PR #24668:
URL: https://github.com/apache/datafusion/pull/24668#discussion_r3882573238
##########
datafusion/physical-expr/src/equivalence/properties/mod.rs:
##########
@@ -240,6 +252,12 @@ impl EquivalenceProperties {
// No point in substituting an expression with itself.
return None;
}
+ if double_negation_input(&r_expr).is_some_and(|expr|
expr.eq(&sort_expr.expr)) {
Review Comment:
Thanks, you are right. Fixed in `2bad6666a`: projection substitution now
walks successive deterministic double-negation pairs while retaining the
original expression for checked evaluation, so composed projections preserve
the full `[key, j]` ordering.
The exact pending-stream cases, N2/N4/N6 and odd/volatile controls, the
aggregate alias, and timestamp `MIN` are covered; full Clippy and the extended
workspace suite pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
