RRXXZZYY commented on PR #5603: URL: https://github.com/apache/datafusion-comet/pull/5603#issuecomment-5487943392
Thanks for the thorough review. I addressed the feedback in `65581cc2` and rebased the branch onto current `main` (`2949fd0d`). - Ordinary imports now retain Arrow's original `field.createVector(allocator)` path. `fieldForAllocation` returns the original `Field` by identity when unchanged, and the import factory is hoisted per `NativeUtil` instance. A regression checks the existing `$data$` list-child behavior. - The duplicate-safe wrappers are now limited to the affected complex subtree. `RenamedStructVector` uses Arrow 18.3's `Field` constructor; the separate construction flag is gone, with the original exported metadata exposed only after the direct children exist. - The internal fallback reason and doc-facing dispatcher explanation are separate, and `struct` is documented as Hybrid. - Duplicate-name integration coverage moved to `create_named_struct.sql` and now includes `struct(a, a)`, nested array/map/struct values, three duplicates, all-null rows, and construction after a supported primitive-key shuffle boundary. - `NativeUtilSuite` now uses scoped resources and explicitly handles the Arrow array/schema handoff on failure paths. Fresh validation on this head: - full `NativeUtilSuite` on Spark 4.0: 11/11 passed; - focused SQL-file regression on Spark 4.0, 3.5, and 3.4: passed on all three profiles; - focused duplicate-struct codegen test on the default Spark 4.1 profile: passed; - Scalastyle: 147 files, 0 errors/warnings; - Spotless on all four changed Scala files and `git diff --check`: passed. The PR description now records the exact checks and remaining local-validation boundaries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
