milenkovicm opened a new pull request, #2405:
URL: https://github.com/apache/datafusion-ballista/pull/2405
Event logs written by `EventLogWriter` (`ballista/history/src/writer.rs`)
now go to `<job_id>.eventlog.running` while a job runs, and are flushed,
closed, and renamed to `<job_id>.eventlog` when the job reaches a terminal
state (success, failure, or cancellation) via `finish_job`; this lets a
directory scan tell running/crashed jobs apart from finished ones by filename
alone, since the history server's existing `.eventlog` extension filter
(`ballista/scheduler/src/history/mod.rs`) already excludes `.running` files
without opening them, avoiding the previous per-tick re-parsing of in-flight
logs.
This would enable custom event log handlers to make difference between
finished and running jobs and would help with external inotify listeners to
make difference between fils. Also it would help with race condition between
job finish and file flush.
Doc comments in `ballista/history/src/lib.rs`,
`writer.rs`, `history/mod.rs`, and
`docs/source/user-guide/history-server.md` were updated to describe the new
two-name lifecycle, and tests were adjusted accordingly: writer.rs's tests were
updated for the new path and a new no-op-finish test was added,
history/mod.rs's `refresh_indexes_a_log_that_gains_its_terminal_record` was
rewritten to exercise a real write-then-rename, and two tests in
`scheduler_server/event_log.rs` that previously only called flush_job (and
would otherwise never see the renamed file) now also call finish_job.
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
