1fanwang commented on code in PR #24838:
URL: https://github.com/apache/datafusion/pull/24838#discussion_r3908607402
##########
datafusion/functions-nested/src/position.rs:
##########
@@ -198,6 +200,12 @@ fn array_position_inner(args: &[ArrayRef]) ->
Result<ArrayRef> {
}
}
+fn resolve_zero_based_start_from(start_from: i64) -> Result<i64> {
+ start_from
+ .checked_sub(1)
+ .ok_or_else(|| exec_datafusion_err!("start_from out of bounds:
{start_from}"))
Review Comment:
Addressed in 6fff9d85d. The message now names the accepted range:
`start_from out of bounds: -9223372036854775808, expected -9223372036854775807
to 9223372036854775807`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
