adriangbot commented on PR #24857: URL: https://github.com/apache/datafusion/pull/24857#issuecomment-5500755168
π€ Benchmark completed (GKE) | [trigger](https://github.com/apache/datafusion/pull/24857#issuecomment-5500235371) **Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) Comparing claude/bytes-map-initial-capacity-accounting (84f07dadabe68e25900b59909c9c0c28e99c7c56) to da89c7c (merge-base) [diff](https://github.com/apache/datafusion/compare/da89c7c85b1c888ba4038317eacbdcfe03ab9b1a..84f07dadabe68e25900b59909c9c0c28e99c7c56) <details><summary>Run configuration</summary> ```yaml run benchmark clickbench_extended env: DATAFUSION_RUNTIME_MEMORY_LIMIT: "4G" ``` </details> <details><summary>CPU Details (lscpu)</summary> ``` Architecture: aarch64 CPU op-mode(s): 64-bit Byte Order: Little Endian CPU(s): 16 On-line CPU(s) list: 0-15 Vendor ID: ARM Model name: Neoverse-V2 Model: 1 Thread(s) per core: 1 Core(s) per cluster: 16 Socket(s): - Cluster(s): 1 Stepping: r0p1 BogoMIPS: 2000.00 Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti L1d cache: 1 MiB (16 instances) L1i cache: 1 MiB (16 instances) L2 cache: 32 MiB (16 instances) L3 cache: 80 MiB (1 instance) NUMA node(s): 1 NUMA node0 CPU(s): 0-15 Vulnerability Gather data sampling: Not affected Vulnerability Indirect target selection: Not affected Vulnerability Itlb multihit: Not affected Vulnerability L1tf: Not affected Vulnerability Mds: Not affected Vulnerability Meltdown: Not affected Vulnerability Mmio stale data: Not affected Vulnerability Reg file data sampling: Not affected Vulnerability Retbleed: Not affected Vulnerability Spec rstack overflow: Not affected Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl Vulnerability Spectre v1: Mitigation; __user pointer sanitization Vulnerability Spectre v2: Mitigation; CSV2, BHB Vulnerability Srbds: Not affected Vulnerability Tsa: Not affected Vulnerability Tsx async abort: Not affected Vulnerability Vmscape: Not affected ``` </details> <details><summary>Details</summary> <p> ``` Comparing HEAD and claude_bytes-map-initial-capacity-accounting -------------------- Benchmark clickbench_extended.json -------------------- βββββββββββββ³ββββββββββββββ³βββββββββββββββββββββββββββββββββββββββββββββββ³ββββββββββββββββ β Query β HEAD β claude_bytes-map-initial-capacity-accounting β Change β β‘βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ© β QQuery 0 β 759.73 ms β 777.73 ms β no change β β QQuery 1 β 191.85 ms β 188.58 ms β no change β β QQuery 2 β 461.18 ms β 449.45 ms β no change β β QQuery 3 β 316.36 ms β 315.46 ms β no change β β QQuery 4 β 1939.19 ms β 1972.42 ms β no change β β QQuery 5 β 17961.07 ms β 18770.57 ms β no change β β QQuery 6 β 2.71 ms β 2.51 ms β +1.08x faster β β QQuery 7 β 6780.67 ms β 6541.07 ms β no change β β QQuery 8 β 413.85 ms β 407.70 ms β no change β β QQuery 9 β 2685.46 ms β 2806.90 ms β no change β β QQuery 10 β 634.33 ms β 657.00 ms β no change β β QQuery 11 β 1907.91 ms β 1769.18 ms β +1.08x faster β β QQuery 12 β 199.35 ms β 187.42 ms β +1.06x faster β β QQuery 13 β 567.73 ms β 537.52 ms β +1.06x faster β βββββββββββββ΄ββββββββββββββ΄βββββββββββββββββββββββββββββββββββββββββββββββ΄ββββββββββββββββ βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ³βββββββββββββ β Benchmark Summary β β β‘βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ© β Total Time (HEAD) β 34821.39ms β β Total Time (claude_bytes-map-initial-capacity-accounting) β 35383.52ms β β Average Time (HEAD) β 2487.24ms β β Average Time (claude_bytes-map-initial-capacity-accounting) β 2527.39ms β β Queries Faster β 4 β β Queries Slower β 0 β β Queries with No Change β 10 β β Queries with Failure β 0 β βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ΄βββββββββββββ Distribution per query (min / mean Β±stddev / max): Comparing HEAD and claude_bytes-map-initial-capacity-accounting -------------------- Benchmark clickbench_extended.json -------------------- βββββββββββββ³ββββββββββββββββββββββββββββββββββββββββββββ³βββββββββββββββββββββββββββββββββββββββββββββββ³ββββββββββββββββ β Query β HEAD β claude_bytes-map-initial-capacity-accounting β Change β β‘βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ© β QQuery 0 β 759.73 / 933.63 Β±104.69 / 1025.92 ms β 777.73 / 847.50 Β±54.54 / 904.14 ms β +1.10x faster β β QQuery 1 β 191.85 / 192.97 Β±0.72 / 194.07 ms β 188.58 / 189.46 Β±0.60 / 190.27 ms β no change β β QQuery 2 β 461.18 / 463.94 Β±2.29 / 466.71 ms β 449.45 / 452.25 Β±2.86 / 457.44 ms β no change β β QQuery 3 β 316.36 / 320.10 Β±2.65 / 323.24 ms β 315.46 / 317.01 Β±1.64 / 320.03 ms β no change β β QQuery 4 β 1939.19 / 2044.28 Β±93.88 / 2205.14 ms β 1972.42 / 2012.03 Β±32.28 / 2066.64 ms β no change β β QQuery 5 β 17961.07 / 18599.98 Β±361.16 / 18964.48 ms β 18770.57 / 18949.41 Β±196.42 / 19309.14 ms β no change β β QQuery 6 β 2.71 / 3.47 Β±1.14 / 5.69 ms β 2.51 / 2.92 Β±0.33 / 3.46 ms β +1.19x faster β β QQuery 7 β 6780.67 / 8768.03 Β±1639.91 / 10478.13 ms β 6541.07 / 7831.91 Β±1401.44 / 9664.85 ms β +1.12x faster β β QQuery 8 β 413.85 / 417.29 Β±2.91 / 422.35 ms β 407.70 / 411.63 Β±2.71 / 415.64 ms β no change β β QQuery 9 β 2685.46 / 2737.34 Β±60.65 / 2850.29 ms β 2806.90 / 2955.32 Β±135.85 / 3181.21 ms β 1.08x slower β β QQuery 10 β 634.33 / 646.41 Β±9.42 / 658.78 ms β 657.00 / 669.50 Β±8.53 / 678.26 ms β no change β β QQuery 11 β 1907.91 / 2042.36 Β±129.72 / 2281.30 ms β 1769.18 / 1963.90 Β±112.13 / 2082.76 ms β no change β β QQuery 12 β 199.35 / 206.27 Β±5.83 / 214.17 ms β 187.42 / 202.18 Β±19.45 / 240.46 ms β no change β β QQuery 13 β 567.73 / 585.03 Β±16.61 / 610.85 ms β 537.52 / 562.53 Β±27.74 / 614.97 ms β no change β βββββββββββββ΄ββββββββββββββββββββββββββββββββββββββββββββ΄βββββββββββββββββββββββββββββββββββββββββββββββ΄ββββββββββββββββ βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ³βββββββββββββ β Benchmark Summary β β β‘βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ© β Total Time (HEAD) β 37961.07ms β β Total Time (claude_bytes-map-initial-capacity-accounting) β 37367.55ms β β Average Time (HEAD) β 2711.51ms β β Average Time (claude_bytes-map-initial-capacity-accounting) β 2669.11ms β β Queries Faster β 3 β β Queries Slower β 1 β β Queries with No Change β 10 β β Queries with Failure β 0 β βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ΄βββββββββββββ ``` </p> </details> <details><summary>Memory Pool Peaks</summary> Peak `MemoryPool` reservation per query β what DataFusion's accounting believes it reserved. Recorded only when the benchmark runs with `DATAFUSION_RUNTIME_MEMORY_LIMIT` set. Base: `da89c7c (merge-base)` | Changed: `claude/bytes-map-initial-capacity-accounting` **`clickbench_extended`** | Query | Base | Changed | Change | | --- | --- | --- | --- | | Query 0 | 812.8 MiB | 846.5 MiB | +4.1% | | Query 1 | 3.4 MiB | 2.4 MiB | -29.4% | | Query 2 | 98.6 MiB | 11.7 MiB | -88.1% | | Query 3 | 11.8 MiB | 11.7 MiB | -0.9% | | Query 4 | 1.4 GiB | 1.4 GiB | +0.1% | | Query 5 | 1.5 GiB | 1.5 GiB | -0.0% | | Query 6 | 104 B | 104 B | +0.0% | | Query 7 | 1.3 GiB | 1.2 GiB | -1.9% | | Query 8 | 37.2 MiB | 37.3 MiB | +0.4% | | Query 9 | 2.1 GiB | 2.1 GiB | -0.5% | | Query 10 | 1.9 MiB | 2.1 MiB | +10.5% | | Query 11 | 2.2 GiB | 2.2 GiB | -0.5% | | Query 12 | 1.3 MiB | 1.0 MiB | -21.2% | | Query 13 | 520 B | 520 B | +0.0% | **Pool accounting vs. process RSS** Max pool peak is the largest reservation any single query in the run reached; peak RSS covers the whole invocation, including data loading and allocator retention, and the two high-water marks need not coincide in time. The gap is therefore an upper bound on what the pool did not account for, not a measurement of it. | Benchmark | Side | Max pool peak | Peak RSS | Gap | RSS / pool | | --- | --- | --- | --- | --- | --- | | clickbench_extended | base (`da89c7c (merge-base)`) | 2.2 GiB | 9.9 GiB | 7.7 GiB | 4.5Γ | | clickbench_extended | changed (`claude/bytes-map-initial-capacity-accounting`) | 2.2 GiB | 10.7 GiB | 8.5 GiB | 4.9Γ | </details> <details><summary>Resource Usage</summary> **clickbench_extended β base (merge-base)** | Metric | Value | |--------|-------| | Wall time | 195.0s | | Peak memory | 9.9 GiB | | Avg memory | 3.7 GiB | | CPU user | 1920.2s | | CPU sys | 108.2s | | Peak spill | 0 B | **clickbench_extended β branch** | Metric | Value | |--------|-------| | Wall time | 190.0s | | Peak memory | 10.7 GiB | | Avg memory | 4.4 GiB | | CPU user | 1873.9s | | CPU sys | 110.8s | | Peak spill | 0 B | </details> --- [File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
