2010YOUY01 commented on PR #24017: URL: https://github.com/apache/datafusion/pull/24017#issuecomment-5511331754
https://github.com/apache/datafusion/pull/24877 tries to apply generator pattern together with explicit states, I'm wondering how you guys think. I'm lean towards keeping the explicit states, because it's more like controlling complexity with a mechanism instead of with discipline. It's also a pattern that can be used brainlessly for more complex state graphs, like joins with spilling (lots of loop edges), and we don't have to invent different patterns for different operators for consistency. I think this PR is pretty clean now, and the quality is maintained by good practice. However, if we don't rely on explicit states, I think it's more likely to get poisoned in the future (e.g. adding mysterious local flags for new features, making it confusing again). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
