stag7824 commented on PR #2373: URL: https://github.com/apache/datafusion-ballista/pull/2373#issuecomment-5515259185
Thanks for reproducing it and for the careful read. All three addressed: 1. **`examples/Cargo.toml:61`** — fixed in dedb6f3, added `arrow-ipc-optimizations` alongside `build-binary` on the `ballista-core` dev-dependency. Verified with `cargo tree -p ballista-examples -e features,dev -i ballista-core`: before, core's feature doesn't appear in the graph under `ballista-examples` at all; after, there's a direct edge from it. Worth noting `mtls-cluster.rs` constructs `BallistaFlightService` directly, so this crate isn't just linking the gated code in unused. 2. **Site count** — corrected to five in the description, and added the `range_shuffle/ipc_file.rs` row. 3. **The safety-relevant config** — added a paragraph under "Are there any user-facing changes?" spelling out exactly the case you flagged: `ballista-executor` opted in with `default-features = false` on `ballista-core` now loses that isolation, since the executor's feature forwards to core's. Said plainly that it's a real behavioural shift for that one configuration, not just a rename. Left the `SKIP_IPC_VALIDATION` const idea for a follow-up rather than folding it in here, since as you said it doesn't change whether this needs merging first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
