alamb opened a new pull request, #2482:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2482

   ## Which issue does this PR close?
   
   N/A — routine dependency maintenance.
   
   ## Rationale for this change
   
   Checking in `Cargo.lock` gives CI reproducible builds and makes dependency 
updates visible in review, per the [current Cargo 
guidance](https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control)
 which now recommends committing the lockfile for libraries as well.
   
   ## What changes are included in this PR?
   
   - Remove `Cargo.lock` from `.gitignore`
   - Check in `Cargo.lock` generated with `cargo update` (all 46 packages 
locked to the latest semver-compatible versions; no `Cargo.toml` changes needed)
   
   ## Are these changes tested?
   
   `cargo test --all-features` passes (22/22 suites, 0 failures).
   
   ## Are there any user-facing changes?
   
   No. This only affects local development and CI of this repository; 
downstream users of the published crate are unaffected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to