github-actions[bot] commented on PR #24698: URL: https://github.com/apache/datafusion/pull/24698#issuecomment-5545681666
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-expr v55.0.0 (current) Built [ 40.021s] (current) Parsing datafusion-expr v55.0.0 (current) Parsed [ 0.082s] (current) Building datafusion-expr v55.0.0 (baseline) Built [ 29.615s] (baseline) Parsing datafusion-expr v55.0.0 (baseline) Parsed [ 0.083s] (baseline) Checking datafusion-expr v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 2.050s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 73.795s] datafusion-expr Building datafusion-expr-common v55.0.0 (current) Built [ 19.705s] (current) Parsing datafusion-expr-common v55.0.0 (current) Parsed [ 0.019s] (current) Building datafusion-expr-common v55.0.0 (baseline) Built [ 19.951s] (baseline) Parsing datafusion-expr-common v55.0.0 (baseline) Parsed [ 0.020s] (baseline) Checking datafusion-expr-common v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.324s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_variant_added.ron Failed in: variant SortProperties:Grouped in /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/sort_properties.rs:43 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 41.092s] datafusion-expr-common Building datafusion-ffi v55.0.0 (current) Built [ 54.397s] (current) Parsing datafusion-ffi v55.0.0 (current) Parsed [ 0.066s] (current) Building datafusion-ffi v55.0.0 (baseline) Built [ 54.465s] (baseline) Parsing datafusion-ffi v55.0.0 (baseline) Parsed [ 0.070s] (baseline) Checking datafusion-ffi v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.348s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_variant_added.ron Failed in: variant FFI_SortProperties:Grouped in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/expr/expr_properties.rs:73 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 111.365s] datafusion-ffi Building datafusion-functions v55.0.0 (current) Built [ 30.371s] (current) Parsing datafusion-functions v55.0.0 (current) Parsed [ 0.087s] (current) Building datafusion-functions v55.0.0 (baseline) Built [ 30.474s] (baseline) Parsing datafusion-functions v55.0.0 (baseline) Parsed [ 0.090s] (baseline) Checking datafusion-functions v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.601s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 63.373s] datafusion-functions Building datafusion-physical-expr v55.0.0 (current) Built [ 28.607s] (current) Parsing datafusion-physical-expr v55.0.0 (current) Parsed [ 0.052s] (current) Building datafusion-physical-expr v55.0.0 (baseline) Built [ 28.710s] (baseline) Parsing datafusion-physical-expr v55.0.0 (baseline) Parsed [ 0.054s] (baseline) Checking datafusion-physical-expr v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.505s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 60.170s] datafusion-physical-expr Building datafusion-physical-optimizer v55.0.0 (current) Built [ 39.772s] (current) Parsing datafusion-physical-optimizer v55.0.0 (current) Parsed [ 0.023s] (current) Building datafusion-physical-optimizer v55.0.0 (baseline) Built [ 40.018s] (baseline) Parsing datafusion-physical-optimizer v55.0.0 (baseline) Parsed [ 0.025s] (baseline) Checking datafusion-physical-optimizer v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.160s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 81.471s] datafusion-physical-optimizer Building datafusion-physical-plan v55.0.0 (current) Built [ 37.714s] (current) Parsing datafusion-physical-plan v55.0.0 (current) Parsed [ 0.164s] (current) Building datafusion-physical-plan v55.0.0 (baseline) Built [ 37.244s] (baseline) Parsing datafusion-physical-plan v55.0.0 (baseline) Parsed [ 0.160s] (baseline) Checking datafusion-physical-plan v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 1.052s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 77.923s] datafusion-physical-plan ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
