NGA-TRAN commented on PR #24501: URL: https://github.com/apache/datafusion/pull/24501#issuecomment-5546159040
Thanks @jayzhan211 and @gene-bordegaray — review comments from both of you are addressed in 4b7373680. **Jay (@jayzhan211)** 1. Monotonic `project` fallback is restricted to the **last** range key. `Range([timestamp, key])` + `date_trunc`/`date_bin` now drops to `UnknownPartitioning`. Covered by `test_range_partitioning_project_rejects_monotonic_transform_on_non_final_key`. 2. Split-point domain vs satisfaction (non-blocking) is tracked as follow-up #24947. **Gene (@gene-bordegaray)** 1. DESC disjointness uses the successor; hour-aligned DESC splits no longer look disjoint. Regression: `test_range_partitioning_descending_uses_successor_for_disjointness`. 2. Non-finite float splits return `None` from `checked_predecessor` / `checked_successor` instead of panicking. 3. Failed split-point projection now fail-closes (`?`) instead of keeping source-domain bounds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
