bharadwaj-pendyala commented on PR #24878:
URL: https://github.com/apache/datafusion/pull/24878#issuecomment-5549098846
Added the `s = 'a' AND 'a' = s` matrix over
`map_string_types_to_utf8view=true,false`; `batch_size` still checks that run
overrides apply.
On current main at `35f58f53c`, reverting
`datafusion/optimizer/src/simplify_expressions/simplify_predicates.rs` to
`20d1c5676^` doesn't reproduce the collapse: the targeted run has 3 tests (the
two 24763-added tests are gone), `SELECT count(*) FROM a WHERE s = 'a' AND 'a'
= s;` returns `1`, and `simplify_predicates.slt:247` passes with `Filter:
test_data.str_col = Utf8View("apple")`. The join and `ON` cases, where 24763
noted canonicalization is skipped for `Join`, and the INT case also return the
right answer. At `max_passes=0`, the unoptimized plan still shows
`CAST(Utf8("a") AS Utf8View)` on both sides, so the input shape hasn't changed;
`simplify_predicates.slt` isn't discriminating on main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
