dwsmith1983 commented on PR #5681: URL: https://github.com/apache/datafusion-comet/pull/5681#issuecomment-5618328156
@peterxcli Andy flagged on #5654 that our two branches rewrite the same list arms in `parquet_convert_array_impl`, and that a mechanical conflict resolution would leave a `List<Struct>` read as `LargeList<Struct>` failing inside the struct arm if #5681 lands first. #5654 now covers that case itself: `resolve_field_mapping`, the struct-holding walk in the adapter and the converter share one `list_element_field` helper for every Arrow list representation, and the converter rebuilds the array in the source layout with the converted elements before casting to the requested type, the same shape as your widened arm, with the per-file mapping plumbed through. A cross-representation `List<Struct>` case is pinned in `struct_field_matching`. So the rebase in either order is taking one arm over the other rather than merging two designs. If #5681 merges first I rebase #5654 onto it and keep your tests. If #5654 goes first, the arm you need is already there and your rebase drops to the `parquet_convert_array_impl` error arm and the docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
