kosiew commented on code in PR #24991: URL: https://github.com/apache/datafusion/pull/24991#discussion_r3988055211
########## datafusion/functions/src/regex/regexpinstr.rs: ########## Review Comment: Could you update this doc comment as well? It still says that a positive `subexpr` selects a group from the first match, while the implementation now correctly selects it from the N-th match. Keeping the comment in sync would help avoid accidentally reintroducing the old behavior later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
