wyatt-herkamp commented on code in PR #25236:
URL: https://github.com/apache/datafusion/pull/25236#discussion_r3996428823
##########
datafusion/core/benches/sql_planner_extended.rs:
##########
@@ -387,8 +410,8 @@ fn criterion_benchmark(c: &mut Criterion) {
let case_heavy_left_join_df =
build_case_heavy_left_join_df(&case_heavy_ctx, &rt);
// really slow :(
- let mut group = c.benchmark_group("sample_size_5");
- group.sample_size(5);
+ let mut group = c.benchmark_group("sample_size_10");
+ group.sample_size(10);
Review Comment:
https://docs.rs/criterion/latest/criterion/struct.Criterion.html#method.sample_size
sample_size must be 10 or greater.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
