wyatt-herkamp opened a new pull request, #25236:
URL: https://github.com/apache/datafusion/pull/25236
## Which issue does this PR close?
- Closes #25235.
## Rationale for this change
Calling schema_name to string is expensive
## What changes are included in this PR?
Uses a hashset of names to prevent reformatting the name
```
logical_unnest_plus_200_columns
time: [1.0161 ms 1.0183 ms 1.0205 ms]
change: [−79.252% −79.058% −78.900%] (p = 0.00 <
0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
4 (4.00%) high mild
1 (1.00%) high severe
logical_unnest_plus_1000_columns
time: [14.751 ms 14.799 ms 14.849 ms]
change: [−86.220% −86.145% −86.079%] (p = 0.00 <
0.05)
Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
1 (1.00%) low mild
6 (6.00%) high mild
2 (2.00%) high severe
logical_unnest_in_200_exprs
time: [3.1697 ms 3.1815 ms 3.1953 ms]
change: [−71.260% −71.088% −70.910%] (p = 0.00 <
0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
3 (3.00%) high mild
3 (3.00%) high severe
```
## What is the testing strategy for this PR?
- Added benchmarks
- Added tests directed to `DedupedProjection`
- Added a sql logic test for a case @xudong963 identified in my initial fix
## Are there any user-facing changes?
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
