rich7420 opened a new pull request, #5878:
URL: https://github.com/apache/datafusion-comet/pull/5878

   ## Which issue does this PR close?
   
   Part of #4616.
   
   ## Rationale for this change
   
   The `round` SQL tests do not check routing with the codegen dispatcher 
disabled or when `allowIncompatible` changes.
   
   ## What changes are included in this PR?
   
   Run the fixture with `allowIncompatible` both disabled and enabled. Assert 
that disabling the dispatcher keeps integral and decimal inputs native and 
sends float and double inputs to Spark with the expected fallback reason.
   
   ## How are these changes tested?
   
   Both configurations pass locally on Spark 4.1. Injected regressions that 
ignore the dispatcher-disable guard or make native support depend on the 
dispatcher are caught by the new assertions.
   
   [Fork 
CI](https://github.com/rich7420/datafusion-comet/actions/runs/34584664224) 
passed, including all six expressions jobs across Spark 3.4–4.2 and macOS Spark 
4.0.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to