osipovartem opened a new pull request, #2502: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2502
`ORDER BY ALL` is supported by Snowflake and is already represented by the shared `OrderByKind::All` AST/parser path. This PR enables that existing capability for `SnowflakeDialect`. The dialect-specific regression test covers a computed select expression together with `DESC NULLS FIRST`; the shared `parse_select_order_by_all` test also begins exercising Snowflake for every supported option combination. Reference: https://docs.snowflake.com/en/sql-reference/constructs/order-by Validation: - `cargo +1.95.0 fmt --all -- --check` - `cargo +1.95.0 test --test sqlparser_snowflake parse_order_by_all` - `cargo +1.95.0 test --test sqlparser_common parse_select_order_by_all` - `cargo +1.95.0 clippy --all-targets -- -D warnings` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
