jayzhan211 commented on code in PR #25250:
URL: https://github.com/apache/datafusion/pull/25250#discussion_r3998870965
##########
datafusion/physical-plan/src/joins/sort_merge_join/exec.rs:
##########
@@ -606,7 +606,11 @@ impl ExecutionPlan for SortMergeJoinExec {
let buffered = buffered.execute(partition, Arc::clone(&context))?;
let batch_size = context.session_config().batch_size();
+ // The stream spills its buffered batches when it cannot grow, so a
+ // pool that budgets spillable and unspillable consumers differently
+ // (`FairSpillPool`) has to know it can.
let reservation =
MemoryConsumer::new(format!("SMJStream[{partition}]"))
+ .with_can_spill(true)
Review Comment:
The registration dates from #5632, when the join could not spill and the
flag was accurate; #11218 added spilling without updating it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
