LinSimon-901101 commented on code in PR #5875:
URL: https://github.com/apache/datafusion-comet/pull/5875#discussion_r3999030284
##########
spark/src/main/scala/org/apache/comet/serde/maps.scala:
##########
@@ -114,7 +117,9 @@ object CometMapValues extends
CometExpressionSerde[MapValues] {
}
}
-object CometMapExtract extends CometExpressionSerde[GetMapValue] {
+object CometMapExtract extends CometExpressionSerde[GetMapValue] with
CodegenDispatchFallback {
Review Comment:
Thanks for the review. I've added and run the requested map-lookup matrix in
`CometCodegenDispatchBenchmark` on Spark 4.1.3, with two warmed runs, fresh-JVM
first-use measurements, and answer/route checks.
The results show a tradeoff: small-map mixed projections improve, while
lookup-only and larger DOUBLE-key maps can be slower than dispatcher-off.
Logs and the full comparison are attached. The routing remains unchanged
pending review of these measured tradeoffs.
[pr-5875-benchmark-evidence.zip](https://github.com/user-attachments/files/32156330/pr-5875-benchmark-evidence.zip)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
