kumarUjjawal commented on code in PR #24916:
URL: https://github.com/apache/datafusion/pull/24916#discussion_r4002487214
##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -1099,7 +1099,9 @@ fn coerce_frame_bound(
}
}
-fn extract_window_frame_target_type(col_type: &DataType) -> Result<DataType> {
+/// The type that RANGE frame offsets are coerced to for an ORDER BY column of
+/// `col_type`, or `None` if the type does not support RANGE frames.
Review Comment:
On `main`, `ORDER BY d, l` stops during planning because `d` has the
`Duration` type. The planner does not examine `l`.
This PR lets the query pass planning. The query then stops during execution
with `Internal error`, as lines 7160–7161 show. Thus, this PR introduces the
`Duration + List<Struct>` execution error.
The comparator fix can remain in a separate PR. In this PR, reject
unsupported nested-list keys in `check_free_range_order_by_types`. Change the
mixed regression test to expect a planning error.
The direct `List<Struct>` cases can remain for the comparator follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
