aoto-tech commented on PR #25289: URL: https://github.com/apache/datafusion/pull/25289#issuecomment-5663491378
@namanjain24-sudo san I opened the issue. This is a little different from the fix I had in mind, so I hope you don’t mind me commenting. 1e-180 seems quite high as the rescaling threshold. For example, squaring 1e-100 gives 1e-200, which is still safe in Float64, but this implementation would rescale it. Since the rescaled path is several times slower, could the threshold be derived from the array length instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
