sunchao commented on PR #5785: URL: https://github.com/apache/datafusion-comet/pull/5785#issuecomment-5672418467
This PR has unfortunately grown quite large through the review iterations ... Maybe we can see if there’s a way to simplify the implementation and tests to keep the scope relatively contained, or split it into a few smaller PRs. For example, one for the core logic and separate follow-ups for some of the review feedback above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
