pingzh opened a new pull request, #5937: URL: https://github.com/apache/datafusion-comet/pull/5937
## Which issue does this PR close? Part 1 of the [five-PR plan for #5775](https://github.com/apache/datafusion-comet/issues/5775#issuecomment-5672549320). The issue remains open for the later steps. ## Rationale for this change Give join wiring, decoded-batch filtering, and Parquet reader attachment clear ownership so the latter two can be reused by TopK. ## What changes are included in this PR? Three commits: 1. Move `DynamicFilterJoinExec` and its existing tests into `dynamic_filter_join`; keep the decoded-batch consumer in `dynamic_filter` with an explicit owner-metrics constructor. 2. Extract the existing reader traversal/remapping into `parquet_reader_filter`, with its null-check recognition test. 3. Use `dynamic_filter_join_*` for all six join filter metrics across Rust, Spark, tests, and docs. The shared consumer receives its metric prefix from its owner. Filtering behavior, eligibility, and execution lifetime are preserved. Most of the diff moves existing code and tests. Metric consumers must use the renamed keys. ## How are these changes tested? - 19 native tests passed: all 18 existing runtime-filter tests plus the planner metric-export test. Each extraction commit also passed the 18 operator tests independently. - 52 Spark 4.1.3 join tests passed on JDK 21. The freshly rebuilt native library and Spark-packaged copy have matching SHA-256 hashes. - Whole-workspace Clippy with all targets and warnings denied, Cargo formatting, Spotless, Scalastyle, and Prettier passed. Native build and Spark 4.1 test compilation passed. - Three independent sub-agents reviewed the final patch and found no remaining concerns; each commit was reviewed before committing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
