pingzh commented on PR #5937: URL: https://github.com/apache/datafusion-comet/pull/5937#issuecomment-5684376842
> let's make the structure for dyn filter like: > > ``` > dynamic_filter/ > ├─ mod.rs (shared runtime-filter components; from dynamic_filter.rs) > ├─ join.rs (DynamicFilterJoinExec) > ├─ parquet_reader.rs (try_attach_parquet_reader_filter, null-check logic) > └─ tests/ > ├─ mod.rs (#[cfg(test)] mod join; mod parquet_reader;) > ├─ join.rs > └─ parquet_reader.rs > ``` > > as we will have topk.rs, agg.rs and their tests @peterxcli that is a good idea. let me update it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
