peterxcli opened a new pull request, #5942: URL: https://github.com/apache/datafusion-comet/pull/5942
## Which issue does this PR close? No linked issue; this adds coverage for binary inputs to `crc32`. ## Rationale for this change The existing `crc32` tests use strings or values cast to strings, so they do not exercise arbitrary binary input such as invalid UTF-8 or embedded zero bytes. ## What changes are included in this PR? Extend the SQL fixture with binary columns and literals covering invalid UTF-8, embedded zero bytes, multibyte UTF-8, empty input, NULL, and a checksum above the signed 32-bit range. Compare results with Spark and require Comet execution. ## How are these changes tested? The `crc32.sql` fixture passes locally through `CometSqlFileTestSuite` on Spark 3.5.9 and 4.1.3 with JDK 17. All four queries compare results with Spark and require Comet execution. `make format` (Spark 3.5) and Apache RAT passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
