dwsmith1983 commented on PR #5880: URL: https://github.com/apache/datafusion-comet/pull/5880#issuecomment-5678119659
> remove the unnecessary `s` prefix at CometTaskMetricsSuite.scala:1205 Removed. Sorry for the delay, that lint note and Andy's two nits from the same evening slipped past my sweep. > Could you carry a short version of the caveat up here? Done: the scaladoc now says the surviving bytes depend on the fallback scan registering its listener after this one, which a `CometSparkToColumnarExec` input always does and a coalesced Spark-scan partition computed first does not. > Could this comment say what the test actually does though? Done: the Iceberg comment now says the scan is its own block with no JVM input, so metrics publish per batch and the test covers the site rather than the order, which stays unguarded for a fused scan until the gate widens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
