geoffreyclaude commented on PR #25112: URL: https://github.com/apache/datafusion/pull/25112#issuecomment-5678051454
> > @geoffreyclaude @Jefffrey in #19383 an `create external catalog` example was added which is provided out of the box by this PR. I triggered an examples failure related to this. Any suggestions on how I should adapt the custom SQL parser example if that particular example is no longer actually custom? > > For now I've adapted the example to use `CREATE FOREIGN CATALOG` as syntax, keeping everything else the same. @pepijnve That's a very reasonable adaptation of the example I think! It keeps the custom sql parser which is the core of the example. Of course it's way less useful as a template since you add native `CREATE EXTERNAL CATALOG` support, and could probably be rewritten from scratch for some new SQL, but that's clearly out of scope of the PR. I'd just suggest adding a short comment to the example explaining that `CREATE EXTERNAL CATALOG` is now natively supported, and this example uses `CREATE FOREIGN CATALOG` purely as demo, if that makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
