comphead commented on issue #25317: URL: https://github.com/apache/datafusion/issues/25317#issuecomment-5689703963
Checklist is a good idea for the review, I personally have a skill that has predefined checklist what to check, we can come up with best practices for datafusion specific review skill which may include: - hotpaths - vectorized processing - code complexity - reuse existing structures, - missgin tests - missing benches - you name it - etc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
