alamb commented on code in PR #25278:
URL: https://github.com/apache/datafusion/pull/25278#discussion_r4029618394
##########
datafusion/sql/src/statement.rs:
##########
@@ -2802,11 +2846,17 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
ast::MergeInsertKind::Row => {
return not_impl_err!("MERGE INSERT ROW is not
supported");
}
+ ast::MergeInsertKind::Wildcard => {
+ return not_impl_err!("MERGE INSERT * is not
supported");
+ }
};
MergeIntoAction::Insert { columns, values }
}
ast::MergeAction::Delete { .. } => MergeIntoAction::Delete,
+ ast::MergeAction::DoNothing { .. } => {
+ return not_impl_err!("MERGE DO NOTHING is not supported");
Review Comment:
I think the DO NOTHING clause is confusing in general -- I think this
comment explains it:
https://github.com/apache/datafusion/pull/25278/changes#r4021127166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
