kosiew commented on code in PR #25386: URL: https://github.com/apache/datafusion/pull/25386#discussion_r4035169338
########## benchmarks/bench.sh: ########## Review Comment: Small integration nit: `all(default)` is documented as running all benchmarks, but the `all` branch does not currently call `run_null_aware_join`, so the new regression benchmark gets silently skipped in the default aggregate run. Could we add `run_null_aware_join` here? If the default runtime makes it unsuitable for `all`, it would be good to explicitly document that instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
