hassaanch23 commented on PR #25402: URL: https://github.com/apache/datafusion/pull/25402#issuecomment-5715896516
@neilconway Thanks! Pushed 2a95a7419. It has your unit tests unchanged, with you credited as co-author, and both simplifications. With the builder now clearing `order_bys`, `order_insensitive_aggregate_discards_order_by` exercises the builder itself rather than the accessor. With the clearing disabled, it fails at `expr.order_bys().is_empty()`, while `order_sensitive_aggregate_keeps_order_by` still passes. The full sqllogictest suite and clippy on all targets pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
