yinli-systems commented on PR #25300: URL: https://github.com/apache/datafusion/pull/25300#issuecomment-5716517266
Thanks @neilconway — addressed all three suggestions in 284a8cf65: - restored the `RowConverter` / IEEE 754 `totalOrder` rationale - extracted `normalize_visible_values` and reused it across union/intersect/distinct/except - reduced the benchmark to the single `create_sliced_float_array(1024 * 1024, 2)` regression case Validation: `cargo fmt --all -- --check`, full all-target/all-feature Clippy with warnings denied, the repository-required extended workspace test suite, and all 128 `datafusion-functions-nested` library tests pass. The focused benchmark runs at about 1.16 µs on this machine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
