villebro opened a new pull request, #2463:
URL: https://github.com/apache/datafusion-ballista/pull/2463
## Summary
The failed TPC-H runs from #2147 were missing `executor.log` from the
artifact even though the cleanup step had just tailed that file, so the file
existed at upload time. The upload step was passing two explicit absolute paths
under `${{ runner.temp }}` in a container job. That is `upload-artifact`'s
documented multiple-path mode: its README says that when multiple paths are
provided, the least common ancestor of all search paths is used as the artifact
root
([docs](https://github.com/actions/upload-artifact#upload-using-multiple-paths-and-exclusions)).
The action source also logs the exact `Multiple search paths detected...` /
`least common ancestor` messages when `globber.getSearchPaths()` returns more
than one path
([source](https://github.com/actions/upload-artifact/blob/main/src/shared/search.ts#L113-L127)).
In the failed run, that documented multi-path handling appears to have
interacted badly with the container path mapping: the action computed `/` as
the LCA and uploaded only one resolved file. Using a single `*.log` glob keeps
artifact discovery rooted in one temp directory, avoiding that multi-path
resolution path while still collecting both `scheduler.log` and `executor.log`.
H2O and TPC-DS use the same cluster harness and had the same upload pattern, so
this PR updates those workflows too.
Fixes #2147.
## Changes
- Upload benchmark cluster logs with a single `${{ runner.temp }}/*.log`
glob.
- Apply the same hardening to the TPC-H, TPC-DS, and H2O workflows.
- Warn when no log files are found instead of silently ignoring the miss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
