HairstonE commented on PR #25390: URL: https://github.com/apache/datafusion/pull/25390#issuecomment-5715422630
@2010YOUY01 Thanks for the quick review. I was hoping this addition to the LimitedDistinctAggregation rule would be small enough to keep the complexity low. The only counter I have to the handwritten example would be queries that are generated from dashboards. Even then I don't know how common this shape would be. Please confirm you would like to avoid this addition to the codebase, and I'll close the PR. I'd appreciate if you could also point me to an area of the project where contributions would be most valuable right now. Just looking to contribute more to DF. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
