andygrove opened a new pull request, #6003:
URL: https://github.com/apache/datafusion-comet/pull/6003
## Which issue does this PR close?
None; filed directly.
## Rationale for this change
Our umbrella workflow is named `CI`. So is the top-level workflow in the core
DataFusion project and in several of the other subprojects. Anywhere runs
from
more than one repository are listed side by side -- the personal Actions
dashboard, workflow notification emails, cross-repository search -- there is
nothing in the name that says which project a run belongs to.
Naming it `Comet CI` makes it self-identifying in those views.
## What changes are included in this PR?
The `name:` of `.github/workflows/ci.yml`, plus a comment recording why it is
project-qualified so it does not get "simplified" back.
Nothing else needs to change, and that is worth being explicit about, because
the risky version of this change would be one that moved a required status
check context:
- The required context in `.asf.yaml` is `Required Checks`, which is the
aggregator **job** name, not the workflow name. Job check-run names are
unaffected by a workflow rename, so branch protection and the merge queue
keep seeing the same context.
- Every other reference to this workflow -- `.asf.yaml`,
`dev/ci/nightly-base.py`
(which queries `actions/workflows/ci.yml/runs`),
`dev/ci/check-ci-config.py`,
`.github/workflows/README.md`, and the contributor guide -- goes through
the
file name `ci.yml`, which does not change.
- `dev/ci/check-ci-config.py`'s job parser matches `name:` at job
indentation,
so the top-level key is outside its scope.
The one visible side effect is the `concurrency` group, which interpolates
`github.workflow`. A run that is already in flight when this lands sits in
the
old group and so will not be cancelled by the next push to that PR. It
self-corrects on the following run.
## How are these changes tested?
Ran the preflight checks locally: `actionlint --shellcheck=off` is clean, and
`check-ci-config.py`, `check-suites.py`, `check-benchmark-runner.py` and
`test-iceberg-shards.py` all pass. Also grepped the tree for any reference to
the workflow by display name rather than by file name; there are none.
The real check is this PR's own run: the workflow should appear as `Comet CI`
while `Required Checks` still reports and still satisfies branch protection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
