andygrove commented on PR #5867: URL: https://github.com/apache/datafusion-comet/pull/5867#issuecomment-5719746429
Triage note: #5875 also closes #5580, and mixes `CodegenDispatchFallback` into the same two serdes (`CometMapExtract` and `CometElementAt` in `maps.scala`) with overlapping `element_at` / `get_map_value` fixtures. @LinSimon-901101 flagged the overlap in that description rather than letting us find it in review, and offered to defer. From reading both, this one looks like the superset: it also closes #5781 for the stateful child being serialized twice under the `CASE WHEN child IS NOT NULL` guard in `size`, `array_append`, `arrays_zip` and `map_from_arrays`, which #5875 does not touch. Are you both happy for this PR to carry the map-lookup serde, with any non-overlapping coverage from #5875 rebased on top once it lands? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
