andygrove commented on PR #5654: URL: https://github.com/apache/datafusion-comet/pull/5654#issuecomment-5719754611
Triage note: #5786 is working the other side of duplicate Parquet field names in the native scan. It rejects ambiguous sibling names before the decoder is built, closing #5783, and explicitly leaves "Spark-compatible duplicate-name resolution" as separate work — which is this PR. You share `parquet_exec.rs`, `schema_adapter.rs` and `eager_page_index_reader_factory.rs`. The risk is that the two disagree on the outcome for the same file: this PR resolves case-sensitive duplicates last-wins the way Spark's `.toMap` does, while #5786 would reject some of those reads before the lookup ever runs. Could you and @ErikBPF work out which cases each of you is claiming, and in what order they land? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
